Fix vega warnings 2 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-yogesh
commented
Nov 22, 2024
chartlets.js/src/lib/hooks.ts
Outdated
Comment on lines
57
to
78
| const signals: { [key: string]: string } = useMemo(() => { | ||
| if (!chart) return {}; | ||
| if (!chart.params) return {}; | ||
| return chart.params | ||
| .filter( | ||
| (param): param is { name: string; select: { on: string } } => | ||
| isObject(param) && | ||
| param !== null && | ||
| "name" in param && | ||
| "select" in param && | ||
| isObject(param.select) && | ||
| param.select?.on != null && | ||
| isString(param.select.on), | ||
| ) | ||
| .reduce( | ||
| (acc, param) => { | ||
| acc[param.select.on] = param.name; | ||
| return acc; | ||
| }, | ||
| {} as { [key: string]: string }, | ||
| ); | ||
| }, [chart]); |
There was a problem hiding this comment.
This is the part that was changed
forman
requested changes
Nov 26, 2024
forman
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the previous PR #37 which had build errors and was then reverted.
What has changed since that PR is
signalsconst that creates the map of listeners and their names.0.0.29for both frontend and backend