Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Switch component #72

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Added Switch component #72

merged 2 commits into from
Dec 12, 2024

Conversation

forman
Copy link
Member

@forman forman commented Dec 10, 2024

@b-yogesh This PR serves as a template for other new components.

Addresses #41

@forman forman requested a review from b-yogesh December 10, 2024 17:14
@forman forman marked this pull request as ready for review December 10, 2024 17:14
Copy link
Collaborator

@b-yogesh b-yogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add new/modify existing demo to show how these new components are used. Would be easier for the user
Decided not to go with this as a UI reference will be added later.

@forman
Copy link
Member Author

forman commented Dec 12, 2024

Let's add new/modify existing demo to show how these new components are used. Would be easier for the user

I actually don't want this now, because it complicates the demo code. Instead I want to add a UI reference later.
E.g. adding a storybook: https://storybook.js.org/
I don't know yet if this is applicable at all. If not, we should create a dedicated demo app that shows all the components that we have. It would also allow for switching plugins! But not now and only if Chartlets becomes a "success" story!

@b-yogesh b-yogesh self-requested a review December 12, 2024 09:25
@b-yogesh b-yogesh merged commit 8114292 into main Dec 12, 2024
1 check passed
@b-yogesh b-yogesh deleted the forman-41-Switch branch December 12, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants