-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/one reg purpose only #2460
Conversation
9a87670
to
3f1be37
Compare
e5738e1
to
e47f08c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this, it was huge! Some line notes in the PR, and one overall comment: The reg 1 tests shouldn't have needed updating because none of our changes at this point should affect reg 1 (unless we're doing custom migration stuff). I think the cause is adding registration_purpose into a v1 schema.
bc_obps/service/tests/data_access_service/test_data_access_opted_in_operation_detail_service.py
Outdated
Show resolved
Hide resolved
b8dc72e
to
38e6723
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrea-williams
From the reporting perspective, the service looks good—currently, only one registration purpose is returned. However, one enhancement needs to be made in AdditionalReportingData.tsx.
Specifically, consider the following change:
const registrationPurpose = (await getRegistrationPurpose(versionId))
?.registration_purpose;
const includeElectricityGenerated =
registrationPurpose === "OBPS Regulated Operation";
This will ensure that the includeElectricityGenerated property is determined correctly based on the registrationPurpose. Let me know if additional clarifications are needed.
38e6723
to
dfa54f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤸
…ationPurpose model; updated fixtures
…g1 e2e tests still need to pass
653be95
to
4be1ece
Compare
Changes made:
Operation
records allow a maximum of oneregistration_purpose
, which is now an attribute on the Operation modelRegistrationPurpose
model has been deleted (no longer necessary)registration_purpose
(232 unit tests were failing to begin with, it was a big refactor)