Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

272 alumina production #2473

Merged
merged 6 commits into from
Nov 28, 2024
Merged

272 alumina production #2473

merged 6 commits into from
Nov 28, 2024

Conversation

gdalcengio
Copy link
Contributor

#272 alumina production page

  • chore: Add in data and configurations needed for alumina production page
  • feat: Add alumina production JSON Schemas and UISchemas + rebase/style/field type edits
  • style: Dynamically update schema on selection of smelter tech type + UISchema and code formatting changes
  • test: Add backend program config test for alumina production

Steps to verify:

  • make reset_db & make run
  • log in as bceid
  • go to reporting/submit annual reports
  • continue or start an SFO
  • continue to facility information and choose Aluminum or alumina production
  • continue to the next page
  • should see just smelter technology type multi select and the 3 source types
  • each smelter tech should add 3 annual fuel amount fields on top
  • each source type when checked should add a box to add emissions
  • each emission should have 1 (or 2 if anode effects) gas type
  • each gas type should have multiple methodologies matching the BCIERS reporting fields excel sheet
  • Anode effects - CF4 - Slope method/Overvoltage method - reporting fields should contain a field with a date widget

Copy link
Contributor

@acatchpole acatchpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@gdalcengio gdalcengio force-pushed the 272_alumina_production branch from 4d558f1 to 5fd52cd Compare November 28, 2024 23:15
@gdalcengio gdalcengio force-pushed the 272_alumina_production branch from a6863c8 to 75bcd31 Compare November 28, 2024 23:33
@gdalcengio gdalcengio merged commit 8e54086 into develop Nov 28, 2024
40 checks passed
@gdalcengio gdalcengio deleted the 272_alumina_production branch November 28, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants