chore: conditionally add superuser envs #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbastia
reviewed
Nov 16, 2024
| @@ -34,6 +34,16 @@ spec: | |||
| - "create_superuser" | |||
| env: | |||
| {{- include "cas-bciers.backendEnvVars" . | nindent 12 }} | |||
| - name: DJANGO_SUPERUSER_USERNAME | |||
There was a problem hiding this comment.
I think it's also missing the "if -dev" toggle here
There was a problem hiding this comment.
..nevermind, it's further up!
pbastia
approved these changes
Nov 16, 2024
| @@ -34,6 +34,16 @@ spec: | |||
| - "create_superuser" | |||
| env: | |||
| {{- include "cas-bciers.backendEnvVars" . | nindent 12 }} | |||
| - name: DJANGO_SUPERUSER_USERNAME | |||
There was a problem hiding this comment.
..nevermind, it's further up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there's also an issue with the superuser being in an init container & how we drop our database beforehand (which means the django auth admin tables don't exist).
This PR is just to fix the side effect of having envs in test/prod that reference a secret that isn't created in those environments, causing a container init config error on deploy. I created a stand-in secret in test to get around that for now. This PR makes those envs conditional on the dev environment.