Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update site visited logic for report verification page #2629

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

vivanovbc
Copy link

@vivanovbc vivanovbc commented Dec 20, 2024

Changes

Acceptance Criteria

  • "Site visited" options (Facility X, Other, None) include required fields for threats to independence and verification conclusion
  • Facility X and Other options include "Type of site visit" field
  • Other option shows additional fields for site name and geographic location
  • Backend model and schema align with frontend changes
  • Form validation works correctly for all new fields and dependencies

Test Plan

  1. Run migrations and start the application
  2. Navigate to the Verification form
  3. Test each "Site visited" option:
    • Verify required fields appear for each option
    • Ensure conditional fields show/hide appropriately
  4. Submit the form with various combinations of inputs
  5. Verify data is correctly saved to the database
  6. Check API responses include all new fields

https://www.loom.com/share/8d7c765181ea42daad40b1b9dac8669a?sid=2b18080d-aff5-4fc5-a73c-f392d83265fb

@vivanovbc vivanovbc self-assigned this Dec 20, 2024
@vivanovbc vivanovbc marked this pull request as ready for review December 30, 2024 00:56
…of github.com:bcgov/cas-registration into fix/update-site-sivited-logic-for-report-verification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant