-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: form submit blocked after error #2642
Open
pbastia
wants to merge
21
commits into
develop
Choose a base branch
from
fix/443-form-submit-blocked-after-error
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbastia
force-pushed
the
fix/443-form-submit-blocked-after-error
branch
from
December 31, 2024 00:01
bba9b81
to
b292c43
Compare
pbastia
force-pushed
the
fix/443-form-submit-blocked-after-error
branch
from
December 31, 2024 00:50
c3631ec
to
1ef8b66
Compare
pbastia
force-pushed
the
fix/443-form-submit-blocked-after-error
branch
from
January 3, 2025 19:19
1ef8b66
to
f0ff8b6
Compare
shon-button
reviewed
Jan 6, 2025
pbastia
force-pushed
the
fix/443-form-submit-blocked-after-error
branch
from
January 7, 2025 22:08
fec5092
to
ed46180
Compare
@shon-button thanks for the review! I fixed the issues, but wasn't able to reproduce the last one on the verification form. It looks like some form elements didn't render on your screenshot, very odd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work done:
NavigationForm
component, to avoid having to implement the funkyuseEffect
everywhere it's neededNotable change:
submitHandler
needs to return a boolean to indicate whether the submission succeeded, server-sideFixes: