ASA Map Legend #3141
Closed
ASA Map Legend #3141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3141 +/- ##
==========================================
- Coverage 84.71% 84.69% -0.02%
==========================================
Files 301 301
Lines 10123 10123
Branches 588 588
==========================================
- Hits 8576 8574 -2
- Misses 1384 1386 +2
Partials 163 163
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It will always be there anyway and removes stutter on zone change click
brettedw
commented
Oct 3, 2023
|
|
||
| const SidePanelGrid = styled(Grid)({ | ||
| minWidth: 400, | ||
| overflowY: 'auto', | ||
| overflowY: 'scroll', |
There was a problem hiding this comment.
This was changed because I believe with those stats the scroll will always be there anyway and it removes a little UI stutter when selecting a different fire zone
conbrad
approved these changes
Oct 3, 2023
| } | ||
|
|
||
| const ZoneSummaryPanel = React.forwardRef((props: Props, ref: React.ForwardedRef<HTMLDivElement>) => { | ||
| ZoneSummaryPanel.displayName = 'ZoneSummaryPanel' | ||
|
|
||
| if (isUndefined(props.selectedFireZone)) { | ||
| const handleClose = () => { | ||
| props.setShowSummaryPanel(false) |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Links:
Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator