Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add station_code field to ModelRunPrediction table #3191

Closed
wants to merge 6 commits into from

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Oct 25, 2023

  • add station_code field to ModelRunPrediction table
  • include station code when querying prediction data

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #3191 (5d2e403) into main (a5ab174) will increase coverage by 0.11%.
Report is 5 commits behind head on main.
The diff coverage is 82.12%.

❗ Current head 5d2e403 differs from pull request most recent head 7cd8d8a. Consider uploading reports for the commit 7cd8d8a to get more accurate results

@@            Coverage Diff             @@
##             main    #3191      +/-   ##
==========================================
+ Coverage   82.05%   82.16%   +0.11%     
==========================================
  Files         267      272       +5     
  Lines        9131     9240     +109     
  Branches      413      413              
==========================================
+ Hits         7492     7592     +100     
- Misses       1526     1535       +9     
  Partials      113      113              
Files Coverage Δ
api/app/db/models/auto_spatial_advisory.py 100.00% <100.00%> (ø)
api/app/db/models/weather_models.py 97.39% <100.00%> (+0.02%) ⬆️
api/app/weather_models/machine_learning.py 90.90% <100.00%> (+4.37%) ⬆️
api/app/weather_models/regression_model.py 100.00% <100.00%> (+12.50%) ⬆️
api/app/weather_models/sample.py 100.00% <100.00%> (ø)
api/app/weather_models/weather_models.py 100.00% <100.00%> (ø)
api/app/weather_models/wind_direction_model.py 100.00% <100.00%> (ø)
api/app/jobs/common_model_fetchers.py 57.80% <50.00%> (-0.34%) ⬇️
api/app/weather_models/wind_direction_utils.py 94.73% <94.73%> (ø)
api/app/weather_models/linear_model.py 88.23% <88.23%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple comments

@dgboss dgboss temporarily deployed to production October 26, 2023 19:51 Inactive
@dgboss dgboss closed this Oct 27, 2023
@dgboss dgboss reopened this Oct 27, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dgboss dgboss closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants