Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grass curing column change #3389

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Grass curing column change #3389

merged 3 commits into from
Feb 8, 2024

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Feb 7, 2024

Making sure we don't autofill over existing values that have been submitted

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e6a915) 81.08% compared to head (86e2d65) 81.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3389   +/-   ##
=======================================
  Coverage   81.08%   81.08%           
=======================================
  Files         280      280           
  Lines        9805     9805           
  Branches      454      454           
=======================================
  Hits         7950     7950           
  Misses       1733     1733           
  Partials      122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brettedw brettedw requested review from dgboss and conbrad February 7, 2024 23:26
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@brettedw brettedw temporarily deployed to production February 8, 2024 00:01 Inactive
@brettedw brettedw merged commit 5e5abf7 into main Feb 8, 2024
30 checks passed
@brettedw brettedw deleted the task/morecast-gc-update branch February 8, 2024 00:14
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Don't autofill over existing values upon MoreCast load
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants