Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3 cleanup job #3396

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Fix S3 cleanup job #3396

merged 3 commits into from
Feb 8, 2024

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Feb 8, 2024

@conbrad conbrad requested review from dgboss and brettedw February 8, 2024 19:22
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e5abf7) 81.08% compared to head (9038245) 81.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3396   +/-   ##
=======================================
  Coverage   81.08%   81.08%           
=======================================
  Files         280      280           
  Lines        9805     9805           
  Branches      454      454           
=======================================
  Hits         7950     7950           
  Misses       1733     1733           
  Partials      122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@conbrad conbrad merged commit cbaa6d9 into main Feb 8, 2024
28 checks passed
@conbrad conbrad deleted the task/fix-s3-cleanup-job branch February 8, 2024 21:14
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants