Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Beta tag from Morecast 2 #3508

Merged
merged 5 commits into from
Apr 3, 2024
Merged

Remove Beta tag from Morecast 2 #3508

merged 5 commits into from
Apr 3, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Apr 2, 2024 •
edited by github-actions bot
Loading

  • Remove Beta tag from Morecast 2
  • Re-route morecast-2 to morecast (both Urls will display the Morecast2 page at the path /morecast)

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@dgboss dgboss requested review from brettedw and conbrad April 2, 2024 21:23
conbrad
conbrad approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Minor: We can also update the Morecast 2 reference in .github/workflows/pr_description.js

web/src/features/landingPage/toolInfo.tsx Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.46%. Comparing base (62cb58c) to head (3bedf85).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3508   +/-   ##
=======================================
  Coverage   80.46%   80.46%           
=======================================
  Files         289      289           
  Lines       10376    10376           
  Branches      514      514           
=======================================
  Hits         8349     8349           
  Misses       1885     1885           
  Partials      142      142

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgboss
Copy link
Collaborator Author

dgboss commented Apr 2, 2024

Nice!

Minor: We can also update the Morecast 2 reference in .github/workflows/pr_description.js

Thanks, done!

brettedw
brettedw approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dgboss dgboss temporarily deployed to production April 2, 2024 23:59 Inactive
@dgboss dgboss merged commit edcbe6f into main Apr 3, 2024
24 checks passed
@dgboss dgboss deleted the task/remove-morecast-beta/3326 branch April 3, 2024 00:34
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
@dgboss @conbrad
Remove Beta tag from Morecast 2 (bcgov#3508)
6a5673c 
Co-authored-by: Conor Brady <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettedw brettedw brettedw approved these changes

@conbrad conbrad conbrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgboss @codecov-commenter @conbrad @brettedw