Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store hourly ffmc from sfms #3550

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Store hourly ffmc from sfms #3550

merged 4 commits into from
Apr 22, 2024

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Apr 19, 2024

  • Adds hourly upload endpoint for hourly FFMC uploads
  • Assumes hourly FFMC includes hour in filename, or we can fallback to creation timestamp to avoid adding more code

Test Links:

Landing Page
MoreCast
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.45%. Comparing base (097f009) to head (634ada7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3550      +/-   ##
==========================================
+ Coverage   80.43%   80.45%   +0.02%     
==========================================
  Files         288      288              
  Lines       10358    10370      +12     
  Branches      507      507              
==========================================
+ Hits         8331     8343      +12     
  Misses       1885     1885              
  Partials      142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@conbrad conbrad requested review from dgboss and brettedw April 19, 2024 23:52
Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@conbrad conbrad temporarily deployed to production April 22, 2024 15:44 Inactive
@conbrad conbrad merged commit 7f3efdf into main Apr 22, 2024
24 checks passed
@conbrad conbrad deleted the task/store-hffmc-sfms-3499 branch April 22, 2024 16:28
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
- Adds hourly upload endpoint for hourly FFMC uploads
- Assumes hourly FFMC includes hour in filename, or we can fallback to creation timestamp to avoid adding more code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants