Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Morecast: Respect precision when setting forecast values #3659

Merged
merged 2 commits into from
May 22, 2024
Merged

Morecast: Respect precision when setting forecast values #3659

merged 2 commits into from
May 22, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented May 22, 2024 •
edited by github-actions bot
Loading

@codecov Codecov
Copy link

codecov bot commented May 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.24%. Comparing base (af0b471) to head (b217eb4).

Files Patch % Lines
...res/moreCast2/components/GridComponentRenderer.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3659      +/-   ##
==========================================
- Coverage   80.24%   80.24%   -0.01%     
==========================================
  Files         291      291              
  Lines       10521    10522       +1     
  Branches      509      510       +1     
==========================================
  Hits         8443     8443              
  Misses       1936     1936              
- Partials      142      143       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgboss dgboss closed this May 22, 2024
@dgboss dgboss reopened this May 22, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dgboss dgboss temporarily deployed to production May 22, 2024 18:05 Inactive
@dgboss dgboss merged commit 4552318 into main May 22, 2024
29 checks passed
@dgboss dgboss deleted the bug/validate-numeric-types/3656 branch May 22, 2024 18:31
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
@dgboss
Morecast: Respect precision when setting forecast values (bcgov#3659)
a36dcef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettedw brettedw brettedw approved these changes

@conbrad conbrad conbrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgboss @conbrad @brettedw