Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink nats deployment memory for dev #3901

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Sep 5, 2024

The bumped memory for testing TPI calculations was committed to main, but only needs to be bumped on a case-by-case basis, this PR shrinks the memory back down to reasonable levels.

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@conbrad conbrad requested a review from dgboss September 5, 2024 17:21
Copy link

sonarqubecloud bot commented Sep 5, 2024

@conbrad conbrad merged commit 34fe9c7 into main Sep 5, 2024
22 checks passed
@conbrad conbrad deleted the task/shink-nats-memory branch September 5, 2024 17:32
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.73%. Comparing base (5b1e4ef) to head (6e44e75).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3901   +/-   ##
=======================================
  Coverage   79.73%   79.73%           
=======================================
  Files         295      295           
  Lines       10891    10891           
  Branches      519      519           
=======================================
  Hits         8684     8684           
  Misses       2063     2063           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants