Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nil check for null or undefined before posting to FireBat API #3961

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Sep 24, 2024

We had a null or undefined check for fuelTypeDetails but not for weatherStation. Replaces all checks with isNil to check for null and undefined.

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.35%. Comparing base (efa0524) to head (2bf27f2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3961   +/-   ##
=======================================
  Coverage   81.35%   81.35%           
=======================================
  Files         298      298           
  Lines       11421    11421           
  Branches      541      541           
=======================================
  Hits         9292     9292           
  Misses       2094     2094           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some unused imports to clean up.

Copy link

@conbrad conbrad merged commit 8b16372 into main Sep 24, 2024
22 of 23 checks passed
@conbrad conbrad deleted the task/nil-check-firebat branch September 24, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants