Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing RDPS data #3996

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Handle missing RDPS data #3996

merged 4 commits into from
Oct 11, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Oct 10, 2024

We run an hourly cron job and often run into a situation where our cron job kicks off and starts downloading RDPS precip gribs before the ECCC has finished uploading them. When this happens we don't have the data we need to subtract precip rasters. This is expected behaviour and we now simply exit and pick things up during the next cron job when ECCC has finished uploading the precip gribs.

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.06%. Comparing base (87a99d8) to head (b20cbc0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3996      +/-   ##
==========================================
+ Coverage   80.02%   80.06%   +0.04%     
==========================================
  Files         302      302              
  Lines       11471    11474       +3     
  Branches      549      549              
==========================================
+ Hits         9180     9187       +7     
+ Misses       2106     2102       -4     
  Partials      185      185              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgboss dgboss requested review from conbrad and brettedw October 10, 2024 21:52
Copy link

@dgboss dgboss temporarily deployed to production October 11, 2024 17:09 Inactive
@dgboss dgboss merged commit 423c52a into main Oct 11, 2024
25 checks passed
@dgboss dgboss deleted the bug/precip-dif-errors/3965 branch October 11, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants