Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StationSourceEnum #4035

Closed
wants to merge 4 commits into from
Closed

Remove StationSourceEnum #4035

wants to merge 4 commits into from

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Oct 21, 2024

Remove StationSourceEnum and make sure all WFWX API calls are mocked for unit tests.

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.99%. Comparing base (8ee7635) to head (9ee9d15).

Files with missing lines Patch % Lines
api/app/jobs/noaa.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4035      +/-   ##
==========================================
- Coverage   80.56%   79.99%   -0.58%     
==========================================
  Files         303      303              
  Lines       11564    11554      -10     
  Branches      549      549              
==========================================
- Hits         9317     9243      -74     
+ Misses       2129     2126       -3     
- Partials      118      185      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgboss dgboss requested review from conbrad and brettedw October 21, 2024 20:07
@dgboss dgboss closed this Oct 21, 2024
@dgboss dgboss reopened this Oct 21, 2024
Copy link

@dgboss dgboss closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants