Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jsonpickle #4113

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Remove jsonpickle #4113

merged 2 commits into from
Nov 20, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Nov 19, 2024

Our code base (including tests) doesn't import from jsonpickle and it doesn't appear to be a dependency of anything so it can be removed.

Also note that our deployments are now using poetry 1.8.4. The poetry.lock included in this PR was generated with poetry v1.8.4.

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@dgboss dgboss requested a review from conbrad November 19, 2024 23:25
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.40%. Comparing base (b04be48) to head (f5738a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4113   +/-   ##
=======================================
  Coverage   80.40%   80.40%           
=======================================
  Files         309      309           
  Lines       11860    11860           
  Branches      537      537           
=======================================
  Hits         9536     9536           
  Misses       2138     2138           
  Partials      186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dgboss dgboss merged commit 6aec69d into main Nov 20, 2024
23 checks passed
@dgboss dgboss deleted the task/remove-jsonpickle branch November 20, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants