Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partitioned table follow up #4118

Merged
merged 38 commits into from
Nov 21, 2024
Merged

Partitioned table follow up #4118

merged 38 commits into from
Nov 21, 2024

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Nov 20, 2024

  • Use python to url encode pg pass for connection
  • Apply encoding fix to partition_and_archive.sh
  • Replace materialized view lookup with partitioned table lookup

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 56.62651% with 36 lines in your changes missing coverage. Please review.

Project coverage is 80.42%. Comparing base (6743a6d) to head (0e428fc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/app/jobs/common_model_fetchers.py 39.28% 34 Missing ⚠️
api/app/weather_models/fetch/predictions.py 92.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4118      +/-   ##
==========================================
- Coverage   80.43%   80.42%   -0.01%     
==========================================
  Files         309      309              
  Lines       11876    11879       +3     
  Branches      537      537              
==========================================
+ Hits         9552     9554       +2     
- Misses       2138     2139       +1     
  Partials      186      186              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:


RUN apt-get update && \
apt-get install -y build-base libpq-dev awscli && \

Check notice

Code scanning / SonarCloud

Arguments in long RUN instructions should be sorted

<!--SONAR_ISSUE_KEY:AZNHkvRQ1WYwIgL1Na1v-->Sort these package names alphanumerically. <p>See more on <a href="https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZNHkvRQ1WYwIgL1Na1v&open=AZNHkvRQ1WYwIgL1Na1v&pullRequest=4118">SonarQube Cloud</a></p>
@conbrad conbrad requested a review from dgboss November 21, 2024 18:31
@conbrad conbrad requested a review from dgboss November 21, 2024 19:14
Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@conbrad conbrad requested a review from dgboss November 21, 2024 21:12
@conbrad conbrad temporarily deployed to production November 21, 2024 21:54 Inactive
Copy link

@conbrad conbrad temporarily deployed to production November 21, 2024 22:32 Inactive
@conbrad conbrad merged commit bb74983 into main Nov 21, 2024
25 checks passed
@conbrad conbrad deleted the task/more-fixes branch November 21, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants