Streamline naming crunchydb cluster #4175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4175 +/- ##
=======================================
Coverage 80.73% 80.73%
=======================================
Files 314 314
Lines 12040 12040
Branches 540 540
=======================================
Hits 9721 9721
Misses 2131 2131
Partials 188 188 ☔ View full report in Codecov by Sentry. |
brettedw
approved these changes
Dec 12, 2024
conbrad
approved these changes
Dec 12, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
envars(which the PGO also uses to construct the role name and pguser secret name)APP_NAMEvariable in crunchy.yaml toCRUNCHY_NAMEto reflect its purpose.APP_NAMEis used elsewhere to refer to the overall application name and the database cluster naming is separateTest Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
PSU Insights