Skip to content

fix: remediations as per discussion #198

fix: remediations as per discussion

fix: remediations as per discussion #198

Triggered via push November 18, 2024 06:23
Status Success
Total duration 1m 39s
Artifacts

ci.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 10 warnings
Lint sources: contracts/token/BiconomyTokenPaymaster.sol#L20
Unexpected import of console file
Lint sources: contracts/token/BiconomyTokenPaymaster.sol#L106
Error message for require is too long: 43 counted / 32 allowed
Lint sources: contracts/token/BiconomyTokenPaymaster.sol#L256
Error message for require is too long: 43 counted / 32 allowed
Lint sources: contracts/token/BiconomyTokenPaymaster.sol#L430
Function body contains 100 lines but allowed no more than 90 lines
Lint sources: contracts/base/BasePaymaster.sol#L7
global import of path @openzeppelin/contracts/utils/introspection/IERC165.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
Lint sources: contracts/base/BasePaymaster.sol#L10
global import of path account-abstraction/core/UserOperationLib.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
Lint sources: contracts/base/BasePaymaster.sol#L18
Immutable variables name are set to be in capitalized SNAKE_CASE
Lint sources: contracts/base/BasePaymaster.sol#L109
GC: Use Custom Errors instead of require statements
Lint sources: contracts/base/BasePaymaster.sol#L156
GC: Use Custom Errors instead of revert statements
Lint sources: contracts/base/BasePaymaster.sol#L163
GC: Use Custom Errors instead of require statements
Lint sources: contracts/base/BasePaymaster.sol#L171
Avoid to use inline assembly. It is acceptable only in rare cases
Lint sources: contracts/interfaces/IBiconomySponsorshipPaymaster.sol#L4
global import of path @openzeppelin/contracts/token/ERC20/IERC20.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
Lint sources: contracts/interfaces/IBiconomySponsorshipPaymaster.sol#L18
'_paymasterId' should not start with _
Lint sources: contracts/interfaces/IBiconomySponsorshipPaymaster.sol#L18
'_value' should not start with _