Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update engine spec and api validation #10

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

AmanRaj1608
Copy link
Collaborator

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

@AmanRaj1608
Copy link
Collaborator Author

  • Using Clone as need to pass the network and chain config to multiple crates
  • Have commented the controller return as the routes now needs to be serialised (not doing this as we might return something else from settlement layer)

Comment on lines +29 to 31
amount_in_usd: f64,
is_smart_contract_deposit: bool,
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this as needed for engine

@ankurdubey521 ankurdubey521 merged commit 2b13055 into feat/settlement-engine Jul 2, 2024
1 check failed
@AmanRaj1608 AmanRaj1608 deleted the fix/engine-spec branch July 11, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants