Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user address to extract_balance_data #17

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

AmanRaj1608
Copy link
Collaborator

No description provided.

@@ -21,6 +21,7 @@ pub struct CovalentTokenData {

#[derive(Deserialize, Serialize, Debug)]
pub struct TokenWithBalance {
pub address: String,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what would be better name here or this is fine?

all TokenWithBalance will have eoa/scw of which the balance is

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good

@AmanRaj1608 AmanRaj1608 requested a review from ankurdubey521 July 4, 2024 10:38
@ankurdubey521 ankurdubey521 merged commit 96fee8d into feat/settlement-engine Jul 8, 2024
1 check passed
@AmanRaj1608 AmanRaj1608 deleted the fix/bridge-result-spec branch July 11, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants