Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update configuration parser and tests #21

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Conversation

AmanRaj1608
Copy link
Collaborator

@AmanRaj1608 AmanRaj1608 commented Jul 11, 2024

Describe your changes

#15

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

Copy link
Collaborator

@ankurdubey521 ankurdubey521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add

  1. RPC URLs
  2. Internal Infra URLs
    to secrets as well

crates/config/src/config.rs Outdated Show resolved Hide resolved
crates/config/src/config.rs Outdated Show resolved Hide resolved
@AmanRaj1608
Copy link
Collaborator Author

I think we should add RPC URLs, Internal Infra URLs

This defeats the purpose of the yaml file then, env will be a large config file, and for every chain integration we need to ask devops to update env

@ankurdubey521
Copy link
Collaborator

I think we should add RPC URLs, Internal Infra URLs

This defeats the purpose of the yaml file then, env will be a large config file, and for every chain integration we need to ask devops to update .env.

We are still going to have a massive number of buckets O(c*c*t*t*2) for which yaml is still pretty helpful.
The number of keys in the env will be O(c) which is < 100, not too bad in my opinion. And since *.yaml was removed from .gitignore, I don't think we can commit prod RPC URLs into github.
Also as discussed with @TakGN, one of us should have access to the secrets manager for updating these secrets during deployments.

@AmanRaj1608 AmanRaj1608 merged commit b38bac4 into dev Jul 11, 2024
1 check failed
@AmanRaj1608 AmanRaj1608 deleted the fix/secrets-yaml branch July 11, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants