Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/config refactor #23

Merged
merged 9 commits into from
Jul 12, 2024
Merged

Feat/config refactor #23

merged 9 commits into from
Jul 12, 2024

Conversation

ankurdubey521
Copy link
Collaborator

@ankurdubey521 ankurdubey521 commented Jul 12, 2024 •
edited
Loading

Describe your changes

Refactor Configuration crate and change the deserialization type of tokens.by_chain.key to string.

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

@ankurdubey521 ankurdubey521 changed the base branch from main to dev July 12, 2024 09:52
@ankurdubey521 ankurdubey521 force-pushed the feat/config-refactor branch from 79ff7b1 to f9c463e Compare July 12, 2024 10:09
@ankurdubey521
Squashed commit of the following:
52fc949 
commit 4f965ce
Author: Ankur Dubey <[email protected]>
Date:   Fri Jul 12 14:08:50 2024 +0400

    Update pr.yaml

commit 62e9acf
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:47:18 2024 +0200

    add resources to cron

commit c0e152f
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:46:56 2024 +0200

    add apiversion to cron job

commit 365120c
Merge: 6960a17 558c2a4
Author: TakGN <[email protected]>
Date:   Thu Jul 11 16:35:30 2024 +0200

    Merge pull request #22 from bcnmy/pipeline

    ci: helm charts and github action workflows

commit 558c2a4
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:33:56 2024 +0200

    newlines

commit 398d46e
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:32:43 2024 +0200

    add newlines

commit 0e60c8b
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:29:20 2024 +0200

    add dockerfile

commit 304ca88
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:26:58 2024 +0200

    ci: helm charts and github action workflows

commit 6960a17
Merge: 544f53c b38bac4
Author: Aman Raj <[email protected]>
Date:   Thu Jul 11 16:51:39 2024 +0400

    Merge pull request #20 from bcnmy/dev

    Dev main sync

commit 544f53c
Merge: a51ba93 daf5530
Author: Ankur Dubey <[email protected]>
Date:   Wed Jun 12 12:35:25 2024 +0400

    Merge branch 'main' of github.com:bcnmy/reflux

commit daf5530
Author: Ankur Dubey <[email protected]>
Date:   Tue Jun 11 20:03:23 2024 +0400

    Create pull_request_template.md
@ankurdubey521 ankurdubey521 merged commit da094f2 into dev Jul 12, 2024
2 checks passed
ankurdubey521 added a commit that referenced this pull request Jul 12, 2024
@ankurdubey521
Refactor Configuration (#24)
b92a6b4 
* Deployment

Co-authored-by: @TakGN

commit 4f965ce
Author: Ankur Dubey <[email protected]>
Date:   Fri Jul 12 14:08:50 2024 +0400

    Update pr.yaml

commit 62e9acf
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:47:18 2024 +0200

    add resources to cron

commit c0e152f
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:46:56 2024 +0200

    add apiversion to cron job

commit 365120c
Merge: 6960a17 558c2a4
Author: TakGN <[email protected]>
Date:   Thu Jul 11 16:35:30 2024 +0200

    Merge pull request #22 from bcnmy/pipeline

    ci: helm charts and github action workflows

commit 558c2a4
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:33:56 2024 +0200

    newlines

commit 398d46e
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:32:43 2024 +0200

    add newlines

commit 0e60c8b
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:29:20 2024 +0200

    add dockerfile

commit 304ca88
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:26:58 2024 +0200

    ci: helm charts and github action workflows

commit 6960a17
Merge: 544f53c b38bac4
Author: Aman Raj <[email protected]>
Date:   Thu Jul 11 16:51:39 2024 +0400

    Merge pull request #20 from bcnmy/dev

    Dev main sync

commit 544f53c
Merge: a51ba93 daf5530
Author: Ankur Dubey <[email protected]>
Date:   Wed Jun 12 12:35:25 2024 +0400

    Merge branch 'main' of github.com:bcnmy/reflux

commit daf5530
Author: Ankur Dubey <[email protected]>
Date:   Tue Jun 11 20:03:23 2024 +0400

    Create pull_request_template.md

* Feat/config refactor (#23)

* refactor: Config

* refactor: tokens.by_chain::key u32->string

* fix: Github Tests

* ping

* merge: dev

* Squashed commit of the following:

commit 4f965ce
Author: Ankur Dubey <[email protected]>
Date:   Fri Jul 12 14:08:50 2024 +0400

    Update pr.yaml

commit 62e9acf
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:47:18 2024 +0200

    add resources to cron

commit c0e152f
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:46:56 2024 +0200

    add apiversion to cron job

commit 365120c
Merge: 6960a17 558c2a4
Author: TakGN <[email protected]>
Date:   Thu Jul 11 16:35:30 2024 +0200

    Merge pull request #22 from bcnmy/pipeline

    ci: helm charts and github action workflows

commit 558c2a4
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:33:56 2024 +0200

    newlines

commit 398d46e
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:32:43 2024 +0200

    add newlines

commit 0e60c8b
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:29:20 2024 +0200

    add dockerfile

commit 304ca88
Author: Takwa <[email protected]>
Date:   Thu Jul 11 16:26:58 2024 +0200

    ci: helm charts and github action workflows

commit 6960a17
Merge: 544f53c b38bac4
Author: Aman Raj <[email protected]>
Date:   Thu Jul 11 16:51:39 2024 +0400

    Merge pull request #20 from bcnmy/dev

    Dev main sync

commit 544f53c
Merge: a51ba93 daf5530
Author: Ankur Dubey <[email protected]>
Date:   Wed Jun 12 12:35:25 2024 +0400

    Merge branch 'main' of github.com:bcnmy/reflux

commit daf5530
Author: Ankur Dubey <[email protected]>
Date:   Tue Jun 11 20:03:23 2024 +0400

    Create pull_request_template.md

* fix: Env Var Err reporting

* fix: pr.yaml

* fix: Wrap CoinGeckoClient in Mutex (#25)

* fix: Wrap CoinGeckoClient in Mutex

* feat: Rate Limiter Governor for socket calls

* fix: points per bucket
@AmanRaj1608 AmanRaj1608 deleted the feat/config-refactor branch July 15, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmanRaj1608 AmanRaj1608 AmanRaj1608 approved these changes

@TakGN TakGN Awaiting requested review from TakGN

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankurdubey521 @AmanRaj1608