feat: decode cached data for engine #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feat/bin-refactor
ankurdubey521
requested changes
Jun 25, 2024
crates/routing-engine/src/engine.rs
Outdated
| } | ||
|
|
||
| impl RoutingEngine { | ||
| pub fn new(aas_client: AccountAggregationService) -> Self { | ||
| pub fn new(aas_client: AccountAggregationService, buckets: Vec<BucketConfig>) -> Self { |
There was a problem hiding this comment.
It would be better to accept &'config Vec<BucketConfig> to prevent cloning later in get_cached_data
|
Unable to close the solver server, tried everything. Thinking to remove the graceful shutdown for now @ankurdubey521 |
I will take a look, if I'm not able to figure something out we remove it |
ankurdubey521
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated engine to estimate the bucket and then get the cached value.
Issue ticket number and link
Checklist before requesting a review