Settlement Engine #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankurdubey521
force-pushed
the
feat/settlement-engine
branch
from
a390892 to
0e078e0
Compare
feat: update engine spec and api validation
ankurdubey521
commented
Jul 2, 2024
fix: update api interface fix: remove graceful shhutdown
fix: update api interface fix: remove graceful shhutdown
AmanRaj1608
reviewed
Jul 4, 2024
Comment on lines
+107
to
+108
| let (direct_assets, non_direct_assets): (Vec<_>, _) = | ||
| user_balances.into_iter().partition(|balance| balance.token == to_token); |
feat: add user address to extract_balance_data
AmanRaj1608
reviewed
Jul 8, 2024
Comment on lines
+157
to
+158
| user_address: sender_address.unwrap_or(&ADDRESS_ZERO.to_string()).clone(), | ||
| recipient: recipient_address.unwrap_or(&ADDRESS_ZERO.to_string()).clone(), |
There was a problem hiding this comment.
Isn't this a problem, it should return error here
There was a problem hiding this comment.
right, will fix it
There was a problem hiding this comment.
Ah so this is by design actually, notice that I accept Option<String> as parameters for the addresses. The reason for this being this same function is used by the indexer to build Estimators, and at that time we don't know the sender/receiver addresses. The good thing is that socket APIs work well even if the account does not hold any funds, so address zero is ideal when running the indexer and building Estimators.
|
Had to migrate everything from |
AmanRaj1608
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.