This repository has been archived by the owner on Sep 11, 2019. It is now read-only.
Skip imports of AnsiblePlugin #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoca
reviewed
Sep 11, 2019
| @@ -273,6 +273,8 @@ def rewrite_imports_in_fst(mod_fst, import_map, collection, spec): | |||
| continue # Skip imports of Base classes | |||
| if len(imp.find_all('name_as_name', value='g:*loader*')) > 0: | |||
| continue # Skip imports of ansible.plugin.loader.py | |||
| if len(imp.find_all('name_as_name', value='g:AnsiblePlugin')) > 0: | |||
There was a problem hiding this comment.
is there a way we can pass a list to value vs creating a bunch of if statements?
would be nicer to have a 'global' that we can append to values as we find them
There was a problem hiding this comment.
I looked earlier and didn't find a way, but now that I am looking again, apparently there is https://redbaron.readthedocs.io/en/latest/querying.html#list-or-tuple. Let me test and update the PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.