Use bufferstream module to properly split client data stream. Resolve…

…s a JSON parsing error caused by separator being sent in the middle of a data chunk.

lib/script.js

@@ -1,7 +1,9 @@
 var _ = require('underscore'),
   net = require('net'),
   events = require('events'),
-  util = require('util');
+  util = require('util'),
+  BufferStream = require('bufferstream'),
+  Buffer = require('buffer').Buffer;
 
 function Script(opts) {
   _.extend(this, {
@@ -66,25 +68,17 @@ Script.prototype.createClient = function(globals) {
       }, 500);
     });
 
-    var data = '';
+
+    var stream = new BufferStream({size:'flexible'});
+    stream.split('\u0000');
+    stream.on('split', function(chunk) {
+      client.end();
+      _this.onExit(chunk);
+    });
+
     client.on('data', function(chunk) {
       _this.dataReceived = true;
-      var chunk = chunk.toString();
-      if ( chunk.charCodeAt( chunk.length - 1 ) !== 0) {
-        data += chunk;
-        // data is still incomplete
-        return;
-      } else {
-        // append all but the separator
-        data += chunk.substr( 0, chunk.length - 1 );
-        client.end();
-      }
-
-      // process parsed data
-      _this.onExit(data.toString());
-
-      // reset data for the next data transfer
-      data = '';
+      stream.write(chunk);
     });
 
   });

package.json

@@ -20,6 +20,7 @@
     "url": "git://github.com/bcoe/sandcastle.git"
   },
   "dependencies": {
+    "bufferstream": ">=0.6.x",
     "optimist": "0.3.4",
     "underscore": ">=1.4.2",
     "micro-test": "1.0.0"