Fix AlignedSpan(..., ::AlignedSpan, ...)
and add test
#11
+4
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes some duplicated code in the tests (the same method is in
runtests.jl
andinterop.jl
).I noticed these issues when looking at beacon-biosignals/DataFrameIntervals.jl#13
If we were to add an
Interval(::AlignedSpan)
constructor, I think the most natural one would bebecause an
AlignedSpan
really is a closed-closed interval of indices. However, we do support mapping to TimeSpans' closed-open world.