Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention AlignedSpans workaround in README #20

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

haberdashPI
Copy link
Member

To let folks know there's a way to do this via pirating.

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #20 (55feaff) into main (d22c243) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   89.50%   89.57%   +0.06%     
==========================================
  Files           1        1              
  Lines         162      163       +1     
==========================================
+ Hits          145      146       +1     
  Misses         17       17              
Impacted Files Coverage Δ
src/DataFrameIntervals.jl 89.57% <0.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericphanson
Copy link
Member

my preferred workaround is to just do

timespanify = :span => ByRow(TimeSpan) => :span
interval_join(transform(df1, timespanify), transform(df2, timespanify); on=:span)

I.e. to match by mapping to TimeSpan's. I feel like that's the most explicit way to say: ignore sample rate etc, just map to Nanosecond timespans and match that way. Whereas an alternate approach would be to map to check all sample rates are equal and then map to Int-valued intervals of indices.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Eric Hanson <[email protected]>
@haberdashPI haberdashPI self-assigned this Oct 17, 2022
@haberdashPI haberdashPI merged commit b86dfbf into main Oct 17, 2022
@haberdashPI haberdashPI deleted the dfl/aligned-spans-workaround branch October 17, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants