Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement multiple inheritance #107

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

implement multiple inheritance #107

wants to merge 2 commits into from

Conversation

jrevels
Copy link
Member

@jrevels jrevels commented Dec 6, 2023

brought to you by: yesterday's MCO -> JFK plane ride

see the added MultV1 test in tour.jl for a simple example

Still needs:

  • proper deprecation of Legolas.parent
  • updates to enable existing test suite to pass (+ fixes for any bugs caught by existing test suite)
  • new tests to cover the multiple inheritance functionality and various edge cases that probably arise
  • more comprehensive tour examples
  • updates to existing documentation/docstrings
  • a new section in the manual providing modeling guidance about when to use multiple inheritance vs. "foreign key-ish" relationships (e.g. using junction records)
  • an implementation of a has_matching_ancestor utility function (since this is now more complicated for downstream users to hand-roll)

Would be very useful if folks could try this PR out in situ in downstream use cases and report back any encountered challenges / bugs / MWEs

@@ -1,7 +1,7 @@
name = "Legolas"
uuid = "741b9549-f6ed-4911-9fbf-4a1c0c97f0cd"
authors = ["Beacon Biosignals, Inc."]
version = "0.5.16"
version = "0.6.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#106 will presumably land before this, in which case this should be bumped again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant