Implement object_name_to_module so it will work for new objects in future #792
Conversation
| @@ -34,6 +34,24 @@ defmodule Stripe.UtilTest do | |||
| assert object_name_to_module("transfer") == Stripe.Transfer | |||
| assert object_name_to_module("transfer_reversal") == Stripe.TransferReversal | |||
| assert object_name_to_module("token") == Stripe.Token | |||
|
|
|||
| assert object_name_to_module("billing_portal.session") == Stripe.BillingPortal.Session | |||
There was a problem hiding this comment.
These become a bit extra, but I figure that I'd add manual tests for any of the handwritten functions I removed
|
@doomspork merged back with main 👍 |
|
Thank you @sb8244, appreciate the multiple PRs this weekend! 🙏 Random but noticed you're a fellow Atlantian (is that a thing?) 🎉 @snewcomer this change looks good to me but I'd like to defer to you for final review/approval. |
|
Wow unexpected! Not too many of us in the Elixir community. |
|
This pull request has been automatically marked as "stale:discard". If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated!. |
|
bump |
|
@sb8244 I will be helping you move forward. Would you mind rebasing the PR? My apologies for the inconvenience. |
|
Any chance this could get merged conflicts resolved and then merged + have a new release cut? I'm looking to use Financial Connections with webhooks and this PR seems like it would fix that. |
|
Thanks for handling @yordis |
|
|
||
| def object_name_to_module("usage_record_summary"), | ||
| do: Stripe.UsageRecordSummary | ||
| def object_name_to_module("test_helpers.test_clock"), do: Stripe.TestClock |
There was a problem hiding this comment.
Hi! I believe there is a mistake made here and this should be Stripe.TestHelpers.TestClock. It is currently breaking api requests to retrieve test clocks. I've filed a bug report #825
This fixes #790 #817 #791 in a way that will also work for the future.
fixes #790 #817 #791