Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Elixir 1.16 warnings #827

Closed
wants to merge 1 commit into from
Closed

Conversation

axelson
Copy link

@axelson axelson commented Jan 25, 2024

  • Fixes Logger.warn deprecation (requires bump to Elixir 1.11 which was released on 2020-10-06)
  • ssl_verify_fun 1.1.6 doesn't compile under Elixir 1.16
  • Remove applications definition and instead only use extra_applications
    • Fixes this warning "both :extra_applications and :applications was found in your mix.exs. You most likely want to remove the :applications key, as all applications are derived from your dependencies"
    • Also the applications listed in apps were just the normal dependencies (and logger)

The only functional change here is upgrading the minimum supported version of Elixir

- Fixes `Logger.warn` deprecation (requires bump to Elixir 1.11 which
  was released on 2020-10-06)
- ssl_verify_fun 1.1.6 doesn't compile under Elixir 1.16
- Remove `applications` definition and instead only use extra_applications
  - Fixes this warning "both :extra_applications and :applications was found in your mix.exs. You most likely want to remove the :applications key, as all applications are derived from your dependencies"
  - Also the applications listed in `apps` were just the normal
    dependencies (and logger)
@axelson axelson requested a review from a team as a code owner January 25, 2024 21:49
@yordis
Copy link
Member

yordis commented Feb 5, 2024

fixed

@yordis yordis closed this Feb 5, 2024
@axelson axelson deleted the clean-up-apps branch February 6, 2024 01:18
@axelson
Copy link
Author

axelson commented Feb 6, 2024

yay! Thank you @yordis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants