Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merge start metadata in stop metadata, include attempts #850

Merged
merged 1 commit into from
Aug 8, 2024
Merged

feat: merge start metadata in stop metadata, include attempts #850

merged 1 commit into from
Aug 8, 2024

Conversation

aloukissas
Copy link
Contributor

This PR includes the start_metadata in the stop_metadata, as recommended in the docs for :telemetry.span/3:

In general, it is highly recommended that StopMetadata should include the values from StartMetadata so that handlers, such as those used for metrics, can rely entirely on the stop event.

We also include the attempts key in the metadata.

@aloukissas aloukissas requested a review from a team as a code owner August 8, 2024 09:52
yordis
yordis approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@yordis yordis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@yordis yordis merged commit 7207c02 into beam-community:main Aug 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yordis yordis yordis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aloukissas @yordis