Skip to content

Commit

Permalink
updated CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
beanumber committed Nov 29, 2016
1 parent dec8640 commit a96c2f6
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
5 changes: 3 additions & 2 deletions R/etl_create.R
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,9 @@
#' db <- src_postgres(dbname = "mtcars", user = "postgres", host = "localhost")
#' cars <- etl("mtcars", db)
#' }
#' if (require(RMySQL)) {
#' db <- src_mysql(dbname = "mtcars", user = "r-user", host = "localhost", password = "mypass")
#' if (require(RMySQL) && mysqlHasDefault()) {
#' db <- src_mysql(dbname = "mtcars", user = "r-user",
#' host = "localhost", password = "mypass")
#' cars <- etl("mtcars", db)
#' }
#' }
Expand Down
3 changes: 2 additions & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
0 errors | 0 warnings | 0 notes

* Code coverage is 85%.
* I believe this will fix the error reported here (https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/etl-00check.html)
* I believe this will fix the error reported here (https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/etl-00check.html). I checked this
with r-hub on Fedora and found no errors.

## Reverse dependencies

Expand Down
5 changes: 3 additions & 2 deletions man/etl_create.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a96c2f6

Please sign in to comment.