a11y: Resolve some aria issues with nav-pills list

beautyjoy · Jun 18, 2024 · 5f1a4d0 · 5f1a4d0
1 parent 6cda24a
commit 5f1a4d0
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 17 deletions.
diff --git a/_layouts/india.html b/_layouts/india.html
@@ -71,17 +71,17 @@ <h1>BJC India Chapter</h1>
                 <div class="hover-accent"> PD 2019</div>
               </a>
             </li>
-            <li role="presentation">
+            <li>
               <a href="{{ site.baseurl }}/india-pd/schedule">
                 <div class="hover-accent">PD 2019 Schedule</div>
               </a>
             </li>
-            <li role="presentation">
+            <li>
               <a href="{{ site.baseurl }}/india-pd/team">
                 <div class="hover-accent">The Team</div>
               </a>
             </li>
-            <li role="presentation">
+            <li>
               <a href="{{ site.baseurl }}/india-pd/persistent-systems">
                 <div class="hover-accent">Persistent Systems</div>
               </a>

diff --git a/_layouts/team.html b/_layouts/team.html
@@ -5,22 +5,22 @@
 <div class="row">
     <div class="col-sm-2">
         <ul class="nav nav-pills nav-stacked internal-links-nav">
-            <li role="presentation">
+            <li>
                 <a href="{{ site.baseurl }}/team/leadership"><div class="hover-accent">BJC Staff</div></a>
             </li>
-            <li role="presentation">
+            <li>
                 <a href="{{ site.baseurl }}/team/edc"><div class="hover-accent">EDC</div></a>
             </li>
-            <li role="presentation">
+            <li>
                 <a href="{{ site.baseurl }}/team/edx"><div class="hover-accent">edX Development</div></a>
             </li>
-            <li role="presentation">
+            <li>
                 <a href="{{ site.baseurl }}/team/master-teachers"><div class="hover-accent">Master Teachers</div></a>
             </li>
-            <li role="presentation">
+            <li>
                 <a href="{{ site.baseurl }}/team/snap"><div class="hover-accent">Snap<em>!</em> Development</div></a>
             </li>
-            <li role="presentation">
+            <li>
                 <a href="{{ site.baseurl }}/team/india"><div class="hover-accent">India Team</div></a>
             </li>
         </ul>
@@ -31,4 +31,4 @@
     </div>
 </div>
 {% endcapture %}
-{% include section.html %}
+{% include section.html %}
diff --git a/_layouts/winter-pd.html b/_layouts/winter-pd.html
@@ -6,26 +6,26 @@
 <div class="row">
     <div class="col-sm-2">
         <ul class="nav nav-pills nav-stacked internal-links-nav">
-            <li role="presentation">
+            <li>
                 <a href="{{ site.baseurl }}/summer-pd/winter-pd/">
                     <div class="hover-accent">About</div>
                 </a>
             </li>
-            <!-- <li role="presentation">
+            <!-- <li>
                 <a href="{{ site.baseurl }}/summer-pd/eligibility"><div class="hover-accent">Eligibility</div></a>
             </li> -->
-            <!-- <li role="presentation">
+            <!-- <li>
                 <a href="{{ site.baseurl }}/summer-pd/cost"><div class="hover-accent">Cost, Stipends and Support</div></a>
             </li> -->
-            <!-- <li role="presentation">
+            <!-- <li>
                 <a href="{{ site.baseurl }}/summer-pd/apply">
                   <div class="hover-accent">Apply to BJC PD</div>
                 </a>
             </li> -->
-            <!-- <li role="presentation">
+            <!-- <li>
                 <a href="{{ site.baseurl }}/summer-pd/resources"><div class="hover-accent">Workshop Resources</div></a>
             </li> -->
-            <!-- <li role="presentation">
+            <!-- <li>
                 <a href="{{ site.baseurl }}/summer-pd/coordinators">
                     <div class="hover-accent">PD Coordinators</div>
                 </a>

diff --git a/team/edc.html b/team/edc.html
@@ -12,4 +12,4 @@ <h3 class="text-uppercase text-center">Education Development Center</h3>
        {% include staff-card.html profile=profile %}
     </div>
     {% endfor %}
-</div>
+</div>
-Original file line number
+Diff line change
@@ Expand Up @@
            {% include staff-card.html profile=profile %}
         </div>
         {% endfor %}
-    </div>
+    </div>