created parser regression test for nested sublocations. #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paleale
pushed a commit
to paleale/poly
that referenced
this pull request
Dec 9, 2023
* created parser regression test for nested sublocations. * integrating @abondrn's fix to genbank parser. * fixed lint issues. * added data for regression test. Co-authored-by: Alex <[email protected]> Co-authored-by: Alex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
I've added a regression test case for an issue with the genbank location parser
parseLocationthat I have yet to solve.Why are you making these changes?
I'm hoping by sharing this test case I can have some help solving this issue. Without it being fixed we won't be able to parse refseq's human genome for instance.
Pre-merge checklist
All of these must be satisfied before this PR is considered
ready for merging. Mergeable PRs will be prioritized for review.
primers/primers_test.gofor what this might look like.CHANGELOG.mdin the[Unreleased]section.