Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove unused scripts #725

Merged
merged 1 commit into from
Dec 9, 2024
Merged

build: remove unused scripts #725

merged 1 commit into from
Dec 9, 2024

Conversation

dkeven
Copy link
Contributor

@dkeven dkeven commented Dec 9, 2024

  • Background
    the legacy change_ip.sh script is replaced by the new change-ip command of olares-cli, we should get rid of this file in the release package to avoid users invoking this script by mistake.
    the scripts check_image_size.sh, scale_minio.sh is unused and should be removed too.

  • Target Version for Merge
    1.10.5, 1.11.0

  • Related Issues
    Script scale_minio.sh not working #723

  • PRs Involving Sub-Systems
    feat: add change ip command Installer#18

  • Other information:
    none

@dkeven dkeven requested a review from eball December 9, 2024 03:56
@dkeven dkeven force-pushed the build/rm_unused_script branch from 9cc909a to 09d1040 Compare December 9, 2024 04:05
@dkeven dkeven changed the title build: remove no longer used change_ip.sh script build: remove unused scripts Dec 9, 2024
@eball eball merged commit c45b299 into main Dec 9, 2024
6 checks passed
@dkeven dkeven deleted the build/rm_unused_script branch December 12, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants