Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support collection.abc.Mapping as resource instead of only dict #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

axelv
Copy link

@axelv axelv commented Jan 3, 2025

This slight modification to the engine relaxes the assumption that a resource node must be a Python dictionary by changing
some isinstance checks:

- if isinstance(node.data, dict):
+ if isinstance(node.data, Mapping):

This allows us to pass Pydantic objects or dataclasses and preserve metadata and methods defined on those objects and solves the issue described here #43.

Let me know what you think and if adaptation are needed 🙌

FYI: I think a similar relaxation of list to Sequence would also be possible 🙂

@axelv
Copy link
Author

axelv commented Jan 6, 2025

@ruscoder What do you think of this approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant