Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix job json #665

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Fix job json #665

merged 3 commits into from
Sep 11, 2023

Conversation

roggervalf
Copy link
Collaborator

@roggervalf roggervalf commented Sep 10, 2023 •
edited
Loading

Changes Made

Fix case when job is stringified on job details, fixes #598

Potential Risks

None

Test Plan

Checklist

  • I've increased test coverage
  • Since this is a public repository, I've checked I'm not publishing private data in the code, commit comments, or this PR.

@roggervalf roggervalf merged commit a76ed5f into master Sep 11, 2023
4 checks passed
@roggervalf roggervalf deleted the fix-job-json branch September 11, 2023 13:23
beequeueci pushed a commit that referenced this pull request Sep 11, 2023
@semantic-release-bot
chore(release): 4.0.1 [skip ci]
97164ed 
### [4.0.1](v4.0.0...v4.0.1) (2023-09-11)

### Bug Fixes

* **job-details:** omit scripts attribute to stringify jobs ([#665](#665)) fixes [#598](#598) ([a76ed5f](a76ed5f))
@beequeueci
Copy link
Collaborator

🎉 This PR is included in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERR: "Converting circular structure to JSON" when the JSON button is clicked
2 participants
@roggervalf @beequeueci