Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Membuat dokumentasi HTML Figure #263

Merged
merged 8 commits into from
Oct 16, 2022
Merged

docs: Membuat dokumentasi HTML Figure #263

merged 8 commits into from
Oct 16, 2022

Conversation

fadelun
Copy link
Contributor

@fadelun fadelun commented Oct 14, 2022 •
edited
Loading

Deskripsi (Description)

Checklist:

Umum:
  • Saya menambah kode basic terbaru.
  • Saya memperbaiki kode basic yang sudah ada.
  • Saya menambah template terbaru.
  • Saya memperbaiki template yang sudah ada.
  • Saya memperbaiki dokumentasi.
  • Saya menambah dokumentasi.
Contributor Requirements (Syarat Kontributor) dan Lain-Lain:
  • Saya sudah membaca (I have read) CONTRIBUTING dan sudah menyetujui semua syarat.
  • Saya telah menambahkan komentar kode yang memberikan penjelasan maksud dari kode yang saya buat.
  • Saya menggunakan bahasa Indonesia untuk memberikan penjelasan dari kode yang saya buat.

Environment

Saya menggunakan (I'm using):

  • os = windows

Testing

  • link html
  • lint css

linked issue #203

@fadelun fadelun requested a review from dhafitf as a code owner October 14, 2022 02:42
@auto-add-label auto-add-label bot added the documentation Improvements or additions to documentation label Oct 14, 2022
@mergify mergify bot requested a review from a team October 14, 2022 02:43
dhafitf
dhafitf requested changes Oct 16, 2022
View reviewed changes
HTML/046 HTML Figure/README.md Outdated Show resolved Hide resolved
HTML/046 HTML Figure/README.md Outdated Show resolved Hide resolved
HTML/046 HTML Figure/README.md Outdated Show resolved Hide resolved
HTML/046 HTML Figure/README.md Outdated Show resolved Hide resolved
HTML/046 HTML Figure/README.md Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team October 16, 2022 12:57
dhafitf
dhafitf approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@dhafitf dhafitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mergify mergify bot requested a review from a team October 16, 2022 15:12
@mergify
Copy link

mergify bot commented Oct 16, 2022

terima kasih atas kontribusinya @fadelun !

@mergify mergify bot merged commit 99de720 into bellshade:main Oct 16, 2022
@dhafitf dhafitf mentioned this pull request Oct 17, 2022
Open
16 tasks
@fadelun fadelun deleted the fadll branch October 18, 2022 14:40
@fadelun fadelun restored the fadll branch October 18, 2022 14:41
@fadelun fadelun deleted the fadll branch October 23, 2022 06:46
@fadelun fadelun restored the fadll branch October 23, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhafitf dhafitf dhafitf approved these changes

@AdityaFitrianaNS AdityaFitrianaNS Awaiting requested review from AdityaFitrianaNS

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation HACKTOBERFEST-ACCEPTED html files markdown files ready-to-merge siap merge sudah direview !
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fadelun @dhafitf