Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: 033 HTML Symbols #266

Merged
merged 2 commits into from
Oct 18, 2022
Merged

docs: 033 HTML Symbols #266

merged 2 commits into from
Oct 18, 2022

Conversation

manh21
Copy link
Member

@manh21 manh21 commented Oct 16, 2022

Deskripsi

Saya menambahkan materi 033 HTML Symbols, materi yang saya ajukan ini merupakan perbaikan dari PR #228 yang belum di merge.

Checklist:

Umum:
  • Saya menambah kode basic terbaru.
  • Saya memperbaiki kode basic yang sudah ada.
  • Saya menambah template terbaru.
  • Saya memperbaiki template yang sudah ada.
  • Saya memperbaiki dokumentasi.
  • Saya menambah dokumentasi.
Contributor Requirements (Syarat Kontributor) dan Lain-Lain:
  • Saya sudah membaca (I have read) CONTRIBUTING dan sudah menyetujui semua syarat.
  • Saya telah menambahkan komentar kode yang memberikan penjelasan maksud dari kode yang saya buat.
  • Saya menggunakan bahasa Indonesia untuk memberikan penjelasan dari kode yang saya buat.

Environment

Saya menggunakan (I'm using):

  • os = linux / windows / macOS

Testing

  • link html
  • lint css

linked issue #203

@auto-add-label auto-add-label bot added the documentation Improvements or additions to documentation label Oct 16, 2022
AdityaFitrianaNS
AdityaFitrianaNS approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@AdityaFitrianaNS AdityaFitrianaNS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

dhafitf
dhafitf requested changes Oct 17, 2022
View reviewed changes
Copy link
Member

@dhafitf dhafitf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gunakan backtick pada seluruh kolom nomor dan entitas, agar markdown tidak merubahnya menjadi sebuah char dan untuk memudahkan pembaca dalam membaca tabel.

@dhafitf dhafitf mentioned this pull request Oct 17, 2022
Open
16 tasks
@manh21
feat: add backtik to nomor dan entitas
3e45b98 
add backtick for ease of use
@manh21 manh21 requested a review from dhafitf October 17, 2022 21:20
dhafitf
dhafitf approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@dhafitf dhafitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dhafitf dhafitf added the ready-to-merge siap merge label Oct 18, 2022
@mergify
Copy link

mergify bot commented Oct 18, 2022

terima kasih atas kontribusinya @manh21 !

@mergify mergify bot merged commit 6e5b198 into bellshade:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaFitrianaNS AdityaFitrianaNS AdityaFitrianaNS approved these changes

@dhafitf dhafitf dhafitf approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation HACKTOBERFEST-ACCEPTED markdown files ready-to-merge siap merge sudah direview !
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manh21 @dhafitf @AdityaFitrianaNS