Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: 044 HTML SVG #270

Merged
merged 6 commits into from
Oct 25, 2022
Merged

docs: 044 HTML SVG #270

merged 6 commits into from
Oct 25, 2022

Conversation

fadelun
Copy link
Contributor

@fadelun fadelun commented Oct 24, 2022 •
edited
Loading

Deskripsi (Description)

Checklist:

Umum:
  • Saya menambah kode basic terbaru.
  • Saya memperbaiki kode basic yang sudah ada.
  • Saya menambah template terbaru.
  • Saya memperbaiki template yang sudah ada.
  • Saya memperbaiki dokumentasi.
  • Saya menambah dokumentasi.
Contributor Requirements (Syarat Kontributor) dan Lain-Lain:
  • Saya sudah membaca (I have read) CONTRIBUTING dan sudah menyetujui semua syarat.
  • Saya telah menambahkan komentar kode yang memberikan penjelasan maksud dari kode yang saya buat.
  • Saya menggunakan bahasa Indonesia untuk memberikan penjelasan dari kode yang saya buat.

Environment

Saya menggunakan (I'm using):

  • os = windows

Testing

  • link html
  • lint css

linked issue #203

@auto-add-label auto-add-label bot added the documentation Improvements or additions to documentation label Oct 24, 2022
@mergify mergify bot requested a review from a team October 24, 2022 03:24
AdityaFitrianaNS
AdityaFitrianaNS approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@AdityaFitrianaNS AdityaFitrianaNS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

dhafitf
dhafitf requested changes Oct 24, 2022
View reviewed changes
HTML/044 HTML SVG/README.md Outdated
<iframe src="html-icon.svg" width="800" height="1200"></iframe>
```

Tidak disarankan untuk menggunakan cara ini karena akan sulit untuk di _maintain_ dan dampak buruk bagi SEO.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Tidak disarankan untuk menggunakan cara ini karena akan sulit untuk di _maintain_ dan dampak buruk bagi SEO.
> Tidak disarankan untuk menggunakan tag `<iframe>` karena akan sulit untuk di _maintain_ dan dampak buruk bagi SEO.

HTML/044 HTML SVG/README.md Outdated
Comment on lines 116 to 117
<!-- If you do not specify the stroke
color the line will not be visible -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubah penjelasan ini menjadi bahasa Indonesia.

@mergify mergify bot requested a review from a team October 24, 2022 13:55
dhafitf
dhafitf approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@dhafitf dhafitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mergify
Copy link

mergify bot commented Oct 25, 2022

terima kasih atas kontribusinya @fadelun !

@mergify mergify bot merged commit 9cc66d2 into bellshade:main Oct 25, 2022
@mergify mergify bot requested a review from a team October 25, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaFitrianaNS AdityaFitrianaNS AdityaFitrianaNS approved these changes

@dhafitf dhafitf dhafitf approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation HACKTOBERFEST-ACCEPTED html files markdown files ready-to-merge siap merge sudah direview !
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fadelun @dhafitf @AdityaFitrianaNS