Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for companies CRM API calls #23

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Conversation

joidegn
Copy link

@joidegn joidegn commented Oct 24, 2023

Content

This allows using company scoped API calls. It's basically copy paste from contacts. The companies default properties are not complete so not sure if people feel that this should not be merged as is. I unfortunately don't have the time to work on it further so wanted to propose to merge it.

@ttyfky ttyfky requested a review from kk-no October 24, 2023 09:19
@kk-no kk-no added the enhancement New feature or request label Oct 26, 2023
@kk-no
Copy link
Member

kk-no commented Oct 26, 2023

Thank you @joidegn
We understood the demand for the Company API and wanted to implement it.
It's okay to merge in between, but I'm going to check the default properties before creating the version. (Therefore, you may have to wait for a while)

@kk-no
Copy link
Member

kk-no commented Oct 26, 2023

@joidegn
Since formatter doesn't seem to be running, please try using $ make fmt and $ make lint.

@joidegn
Copy link
Author

joidegn commented Oct 26, 2023

@joidegn Since formatter doesn't seem to be running, please try using $ make fmt and $ make lint.

done

@kk-no
Copy link
Member

kk-no commented Oct 31, 2023

@joidegn
Thank you for your response!
I will create a new version after correcting the TODO part, so please wait for a while.

@kk-no kk-no merged commit 4f5adb2 into belong-inc:main Oct 31, 2023
1 check passed
@kk-no
Copy link
Member

kk-no commented Nov 15, 2023

We've released v0.7.0 containing this PR.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants