Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements Unmarshaler and Stringer interface for HsInt #29

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Implements Unmarshaler and Stringer interface for HsInt #29

merged 3 commits into from
Jan 11, 2024
+71 −4

Conversation

kk-no
Copy link
Member

@kk-no kk-no commented Dec 27, 2023 •
edited
Loading

What to do

Fix an Company API error when unmarshaling company objects.

  • Added UnmarshalJSON and String methods to HsInt.

Background

The property types for the company model seems to be incorrect.
For unclear reasons Hubspot uses strings for basically everything.

#26

Acceptance criteria

@kk-no kk-no added the bug Something isn't working label Dec 27, 2023
@kk-no kk-no self-assigned this Dec 27, 2023
@kk-no kk-no requested a review from a team December 28, 2023 02:01
@kk-no kk-no marked this pull request as ready for review December 28, 2023 02:01
ttyfky
ttyfky reviewed Dec 28, 2023
View reviewed changes
company_test.go Outdated Show resolved Hide resolved
@kk-no kk-no requested a review from ttyfky December 28, 2023 03:09
Atsushi6263220317
Atsushi6263220317 approved these changes Jan 11, 2024
View reviewed changes
Copy link

@Atsushi6263220317 Atsushi6263220317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kk-no kk-no merged commit d426e53 into main Jan 11, 2024
2 checks passed
@kk-no kk-no deleted the implements-hsint-unmarshaler-and-stringer branch January 11, 2024 05:39
@kk-no kk-no mentioned this pull request Jan 11, 2024
Open
@kk-no kk-no mentioned this pull request Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atsushi6263220317 Atsushi6263220317 Atsushi6263220317 approved these changes

@ttyfky ttyfky ttyfky approved these changes

@shigwata shigwata Awaiting requested review from shigwata

@sn1w sn1w Awaiting requested review from sn1w

@dys6 dys6 Awaiting requested review from dys6

Assignees

@kk-no kk-no

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kk-no @ttyfky @Atsushi6263220317