CI preparations #14
CI preparations #14
Conversation
|
|
|
@zxqfox @Yeti-or and @awinogradov can some of you check? |
|
I'll wait till sunday and merge. Please check if you can |
| () => (cell, naming) => { | ||
| expect(naming).toBe('[origin]'); | ||
|
|
||
| return `${cell.layer}.blocks/${cell.entity.block}/${cell.entity.block}.${cell.tech}`; |
There was a problem hiding this comment.
file.naming.stringify doesnt work well?
There was a problem hiding this comment.
I also mocked getter of naming (see few lines before - naming is simple string) so true bem/sdk.naming.*.stringify will fail.
Plugin doesn't use bem/sdk.* directly only through "helpers". After #10 we will remove helpers and such mocks won't be needed.
On the other side mocking of all dependencies is good for unit testing. Whole thing is tested by e2e
test/unit/generator.test.js
Outdated
| it('should filter nonexistent files', () => { | ||
| fs.existsSync.mockImplementation(path => { | ||
| switch (path) { | ||
| case 'dir/foo.js': |
There was a problem hiding this comment.
Не хочешь оформить в виде hash?
const inMemoryFs = { dir: { 'foo.js': 'qwe' } }, и возвращать _.flat(inMemoryFs).hasOwnKey(path)
Ну или хотя бы return {'dir/foo.js': true, 'dir/foo.js': false}[path];
Switch выглядит громостко
There was a problem hiding this comment.
For now fs.existsSync.mockImplementation(path => path === 'dir/foo.js'); is the smallest
Addressed to #11 and #3