Configurable Git commit, user and email #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for configuring the Git commit message, user name and user email. - Run `npm audit fix` to resolve vulnerability. - Fix prettier complaining about line-endings on Windows. - Skip test that is not supported on Windows. Relates to benchmark-action#234.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm audit fixto resolve vulnerability.Relates to #234.
I'm not particularly happy with how the config is passed around, but the current design of the Git functions makes adding new parameters difficult and the functions aren't encapsulated in a class to associate some state with. Happy to refactor to whatever is preferred, then I can update the tests to properly test things as I'm currently avoiding a big test refactor for the Git history with a call to
slice(1)to skip the new first parameter.I also haven't yet implemented support for templating as suggested pending an agreement on the above.