Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine _Py_stat_struct if Python 3.11 or later #142

Merged
merged 2 commits into from
Aug 27, 2023

Conversation

cielavenir
Copy link
Contributor

To address #141 .

I considered some approaches, but I can see that MS_WINDOWS's _Py_stat_struct definition can be seen from python source code, not 3rdparty modules, so maybe redefining is better.

@benhoyt
Copy link
Owner

benhoyt commented Aug 27, 2023

Looks like the 2.7 and macOS GitHub Actions are failing (though not due to this PR).

Note that Python 3.11 builds succeed on GitHub Actions even without this PR, so I just want to verify this actually fixes the issue in #141. Presumably it's a GCC version thing. Can you reproduce that issue, and are you sure that this fix solves the issue?

@benhoyt benhoyt mentioned this pull request Aug 27, 2023
@benhoyt
Copy link
Owner

benhoyt commented Aug 27, 2023

Per comment on #143, this did actually fail on Windows / Python 3.11 previously, we just weren't seeing it because setup.py fell back to just using the (slow) Python version. This seems to fix that.

2.7 and macOS builds are failing in CI, but that's not related to this PR. Merging.

@benhoyt benhoyt merged commit 7ee0915 into benhoyt:master Aug 27, 2023
8 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants